net: improve network family autoselection handle handling #48464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
This was referenced Jun 15, 2023
github-actions
bot
removed
the
request-ci
29 tasks
github-actions
bot
removed
the
request-ci
benjamingr
approved these changes
Jun 24, 2023
|
I'll check the failing test locally this evening and then I'll update and finally merge this. |
ShogunPanda
force-pushed
the
network-selection-handle-improvements
branch
from
5388aa7 to
16ab933
Compare
github-actions
bot
removed
the
request-ci
24 tasks
marco-ippolito
approved these changes
Jun 27, 2023
ShogunPanda
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in fddd3ff |
This was referenced Jun 28, 2023
This was referenced Jul 2, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 3, 2023
PR-URL: #48464 Fixes: npm/cli#6409 Fixes: KararTY/dank-twitch-irc#13 Fixes: #47644 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
hail2u
added a commit
to hail2u/hail2u.net
that referenced
this pull request
Jul 16, 2023
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48464 Fixes: npm/cli#6409 Fixes: KararTY/dank-twitch-irc#13 Fixes: nodejs#47644 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48464 Fixes: npm/cli#6409 Fixes: KararTY/dank-twitch-irc#13 Fixes: nodejs#47644 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
|
This commit does not land cleanly on |
ruyadorno
added
the
backport-requested-v18.x
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes network family autoselections in three area:
TLSSocketwith a manually set backingSocketwas used. See: PSA: If you're on node20.0.0and above, and want to use this library withclient.configuration.connection.secure === true, use the argument--no-network-family-autoselectionKararTY/dank-twitch-irc#13 (comment)AbortSignalwhen using network family auto selection.Fixes: npm/cli#6409
Fixes: KararTY/dank-twitch-irc#13
Fixes: #47644
CC: @tniessen @silverwind